[PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

Subsystems: networking drivers, the rest, usb networking drivers

STALE3556d REVIEWED: 3 (0M)

3 review trailers.

4 messages, 3 authors, 2016-11-10 · open the first message on its own page

[PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

From: Chris Roth <hidden>
Date: 2016-11-07 22:59:31

From: Allan Chou <redacted>

Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
Bridge Controller (Vendor=04b4 ProdID=3610).

Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
with the Kensington SD4600P USB-C Universal Dock with Power,
which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
Controller.

A similar patch was signed-off and tested-by Allan Chou
[off-list ref] on 2015-12-01.

Allan verified his similar patch on x86 Linux kernel 4.1.6 system
with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.

Tested-by: Allan Chou <redacted>
Tested-by: Chris Roth <redacted>
Tested-by: Artjom Simon <redacted>

Signed-off-by: Allan Chou <redacted>
Signed-off-by: Chris Roth <redacted>
---
 drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index e6338c1..8a6675d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
     .tx_fixup = ax88179_tx_fixup,
 };

+static const struct driver_info cypress_GX3_info = {
+    .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
+    .bind = ax88179_bind,
+    .unbind = ax88179_unbind,
+    .status = ax88179_status,
+    .link_reset = ax88179_link_reset,
+    .reset = ax88179_reset,
+    .stop = ax88179_stop,
+    .flags = FLAG_ETHER | FLAG_FRAMING_AX,
+    .rx_fixup = ax88179_rx_fixup,
+    .tx_fixup = ax88179_tx_fixup,
+};
+
 static const struct driver_info dlink_dub1312_info = {
     .description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter",
     .bind = ax88179_bind,
@@ -1718,6 +1731,10 @@ static const struct usb_device_id products[] = {
     , USB_DEVICE(0x0b95, 0x178a),
     .driver_info = (unsigned long)&ax88178a_info,
 }, {
+    /* Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller */
+    USB_DEVICE(0x04b4, 0x3610),
+    .driver_info = (unsigned long)&cypress_GX3_info,
+}, {
     /* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */
     USB_DEVICE(0x2001, 0x4a00),
     .driver_info = (unsigned long)&dlink_dub1312_info,
-- 
2.7.4

Re: [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2016-11-08 06:48:46

On Mon, Nov 07, 2016 at 04:44:20PM -0600, Chris Roth wrote:
quoted hunk
From: Allan Chou <redacted>

Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
Bridge Controller (Vendor=04b4 ProdID=3610).

Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
with the Kensington SD4600P USB-C Universal Dock with Power,
which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
Controller.

A similar patch was signed-off and tested-by Allan Chou
[off-list ref] on 2015-12-01.

Allan verified his similar patch on x86 Linux kernel 4.1.6 system
with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.

Tested-by: Allan Chou <redacted>
Tested-by: Chris Roth <redacted>
Tested-by: Artjom Simon <redacted>

Signed-off-by: Allan Chou <redacted>
Signed-off-by: Chris Roth <redacted>
---
 drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index e6338c1..8a6675d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
     .tx_fixup = ax88179_tx_fixup,
 };

+static const struct driver_info cypress_GX3_info = {
+    .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
+    .bind = ax88179_bind,
+    .unbind = ax88179_unbind,
+    .status = ax88179_status,
+    .link_reset = ax88179_link_reset,
+    .reset = ax88179_reset,
+    .stop = ax88179_stop,
+    .flags = FLAG_ETHER | FLAG_FRAMING_AX,
+    .rx_fixup = ax88179_rx_fixup,
+    .tx_fixup = ax88179_tx_fixup,
+};
Your tabs got eaten and converted to spaces, making this patch
impossible to apply :(

And you forgot to list what changed from v3, please put that below the
--- line.
thanks,

greg k-h

[PATCH v5] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

From: <hidden>
Date: 2016-11-08 22:08:36

From: Allan Chou <redacted>

Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
Bridge Controller (Vendor=04b4 ProdID=3610).

Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
with the Kensington SD4600P USB-C Universal Dock with Power,
which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
Controller.

A similar patch was signed-off and tested-by Allan Chou
[off-list ref] on 2015-12-01.

Allan verified his similar patch on x86 Linux kernel 4.1.6 system
with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.

Tested-by: Allan Chou <redacted>
Tested-by: Chris Roth <redacted>
Tested-by: Artjom Simon <redacted>

Signed-off-by: Allan Chou <redacted>
Signed-off-by: Chris Roth <redacted>
---
Changes in v4, v5:
 - Add verification of patch on 4.8.6, 4.9-rc4 (v4)
 - Add tester Artjom Simon [off-list ref] (v4)
 - Reformat spaces to tabs (v5)

 drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index e6338c1..8a6675d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
 	.tx_fixup = ax88179_tx_fixup,
 };
 
+static const struct driver_info cypress_GX3_info = {
+	.description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
+	.bind = ax88179_bind,
+	.unbind = ax88179_unbind,
+	.status = ax88179_status,
+	.link_reset = ax88179_link_reset,
+	.reset = ax88179_reset,
+	.stop = ax88179_stop,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
+	.rx_fixup = ax88179_rx_fixup,
+	.tx_fixup = ax88179_tx_fixup,
+};
+
 static const struct driver_info dlink_dub1312_info = {
 	.description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter",
 	.bind = ax88179_bind,
@@ -1718,6 +1731,10 @@ static const struct usb_device_id products[] = {
 	USB_DEVICE(0x0b95, 0x178a),
 	.driver_info = (unsigned long)&ax88178a_info,
 }, {
+	/* Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller */
+	USB_DEVICE(0x04b4, 0x3610),
+	.driver_info = (unsigned long)&cypress_GX3_info,
+}, {
 	/* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */
 	USB_DEVICE(0x2001, 0x4a00),
 	.driver_info = (unsigned long)&dlink_dub1312_info,
-- 
2.7.4

Re: [PATCH v5] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

From: David Miller <davem@davemloft.net>
Date: 2016-11-10 02:47:12

From: <redacted>
Date: Tue, 8 Nov 2016 16:08:01 -0600
From: Allan Chou <redacted>

Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
Bridge Controller (Vendor=04b4 ProdID=3610).

Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
with the Kensington SD4600P USB-C Universal Dock with Power,
which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
Controller.

A similar patch was signed-off and tested-by Allan Chou
[off-list ref] on 2015-12-01.

Allan verified his similar patch on x86 Linux kernel 4.1.6 system
with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.

Tested-by: Allan Chou <redacted>
Tested-by: Chris Roth <redacted>
Tested-by: Artjom Simon <redacted>

Signed-off-by: Allan Chou <redacted>
Signed-off-by: Chris Roth <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help