Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements)
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-11-03 15:48:38
Also in:
linux-mm, lkml
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-11-03 15:48:38
Also in:
linux-mm, lkml
Hi, Sorry for not chipping in earlier - LPC is taking my time.
quoted
quoted
quoted
Looks like we are missing a kfree(family->attrbuf); on error path, but it is not related to Johannes' recent patches.
Actually, I think it *is* related to my patch - I inserted the code there in the wrong place or so. I'll find a fix for that when I'm back home, or you (Cong) can submit yours. It wasn't likely that this was the problem though, since that's just an error path that should never happen (we have <30 genl families, and a 16-bit space for their IDs)
I realized that kmemleak is not scanning the __ro_after_init section... Following patch solves the false positives but I wonder if it's the right/acceptable solution.
Hah, makes sense to me, but I guess we really want Catalin to comment :) johannes