Thread (33 messages) 33 messages, 6 authors, 2016-12-04

Re: Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters

From: Eric Dumazet <hidden>
Date: 2016-11-30 17:36:23

On Wed, 2016-11-30 at 18:46 +0200, Saeed Mahameed wrote:
we had/still have the proper stats they are the ones that
mlx4_en_fold_software_stats is trying to cache into  (they always
exist),
but the ones that you are trying to read from (the mlx4 rings) are gone !

This bug is totally new and as i warned, this is another symptom of
the real root cause (can't sleep while reading stats).

Eric what do you suggest ? Keep pre-allocated MAX_RINGS stats  and
always iterate over all of them to query stats ?
what if you have one ring/none/1K ? how would you know how many to query ?
I am suggesting I will fix the bug I introduced.

Do not panic.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help