Re: [PATCH RFC v2] ethtool: implement helper to get flow_type value

On Tue, 2016-11-29 at 15:21 +0000, Jakub Kicinski wrote:

On Mon, 28 Nov 2016 15:03:43 -0800, Jacob Keller wrote:

quoted

+static inline __u32 ethtool_get_flow_spec_type(__u32 flow_type)
+{
+	return flow_type & (FLOW_EXT | FLOW_MAC_EXT);

I don't have anything of substance to say but I think you are missing
a
negation (~) here compared to the code you are replacing ;)

HAH! Yes you are right. I made a mistake when copying this out of my
driver header file.

Will fix. Sorry for the thrash, and thanks for catching my mistake.

Regards,
Jake