Re: [PATCH V3 net-next 05/15] smc: CLC handshake (incl. preparation steps)
flat view
From: David Miller <davem@davemloft.net>
Date: 2016-11-26 01:53:54
Also in:
linux-s390
From: Ursula Braun <redacted> Date: Thu, 24 Nov 2016 16:06:35 +0100
quoted hunk ↗ jump to hunk
+struct smc_clc_msg_hdr { /* header1 of clc messages */ + u8 eyecatcher[4]; /* eye catcher */ + u8 type; /* proposal / accept / confirm / decline */ + __be16 length; +#if defined(__BIG_ENDIAN_BITFIELD) + u8 version : 4, + flag : 1, + rsvd : 3; +#elif defined(__LITTLE_ENDIAN_BITFIELD) + u8 rsvd : 3, + flag : 1, + version : 4; +#endif +} __packed;
Please get rid of all of these __packed attributes. They are likely completely unnecessary and the code generated for this construct on certain architectures is amazingly inefficient. Describe the on-wire datastructures properly with fixed sized types and any padding or overlapping, as needed.