Thread (3 messages) flat view 3 messages, 3 authors, 2016-11-24

Re: [PATCH] bnxt_en: Fix a VXLAN vs GENEVE issue

From: Michael Chan <michael.chan@broadcom.com>
Date: 2016-11-22 07:15:31
Also in: kernel-janitors

On Mon, Nov 21, 2016 at 9:14 PM, Christophe JAILLET
[off-list ref] wrote:
Knowing that:
  #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_VXLAN        (0x1UL << 0)
  #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_GENEVE       (0x5UL << 0)
and that 'bnxt_hwrm_tunnel_dst_port_alloc()' is only called with one of
these 2 constants, the TUNNEL_DST_PORT_ALLOC_REQ_TUNNEL_TYPE_GENEVE can not
trigger.

Replace the bit test that overlap by an equality test, just as in
'bnxt_hwrm_tunnel_dst_port_free()' above.

Signed-off-by: Christophe JAILLET <redacted>
Thanks.

Acked-by: Michael Chan <michael.chan@broadcom.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help