Thread (18 messages) flat view 18 messages, 3 authors, 2016-11-19

Re: [PATCH 3/5] virtio_net: Add XDP support

From: John Fastabend <john.fastabend@gmail.com>
Date: 2016-11-19 01:03:02

On 16-11-18 03:23 PM, Eric Dumazet wrote:
On Fri, 2016-11-18 at 11:00 -0800, John Fastabend wrote:
quoted
From: Shrijeet Mukherjee <redacted>
quoted
 #include <linux/slab.h>
@@ -81,6 +82,8 @@ struct receive_queue {
 
 	struct napi_struct napi;
 
+	struct bpf_prog *xdp_prog;
Please add proper sparse annotation, as in 

	struct bpf_prog __rcu *xdp_prog;

And run sparse ;)

CONFIG_SPARSE_RCU_POINTER=y

make C=2 drivers/net/virtio_net.o


Yep will do thanks! And I will fix the other comment as well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help