Thread (2 messages) flat view 2 messages, 2 authors, 2016-11-17

Re: [PATCH net-next] netpoll: more efficient locking

From: David Miller <davem@davemloft.net>
Date: 2016-11-17 01:59:37

From: Eric Dumazet <redacted>
Date: Wed, 16 Nov 2016 14:54:50 -0800
From: Eric Dumazet <edumazet@google.com>

Callers of netpoll_poll_lock() own NAPI_STATE_SCHED

Callers of netpoll_poll_unlock() have BH blocked between
the NAPI_STATE_SCHED being cleared and poll_lock is released.

We can avoid the spinlock which has no contention, and use cmpxchg()
on poll_owner which we need to set anyway.

This removes a possible lockdep violation after the cited commit,
since sk_busy_loop() re-enables BH before calling busy_poll_stop()

Fixes: 217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help