Re: [PATCH] netronome: don't access real_num_rx_queues directly
From: Jakub Kicinski <hidden>
Date: 2016-11-16 16:37:07
On Wed, Nov 16, 2016 at 6:10 AM, Arnd Bergmann [off-list ref] wrote:
The netdev->real_num_rx_queues setting is only available if CONFIG_SYSFS
is enabled, so we now get a build failure when that is turned off:
netronome/nfp/nfp_net_common.c: In function 'nfp_net_ring_swap_enable':
netronome/nfp/nfp_net_common.c:2489:18: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?
As far as I can tell, the check here is only used as an optimization that
we can skip in order to fix the compilation. If sysfs is disabled,
the following netif_set_real_num_rx_queues() has no effect.
Fixes: 164d1e9e5d52 ("nfp: add support for ethtool .set_channels")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Acked-by: Jakub Kicinski <redacted> Thanks Arnd! This is needed in net-next only.