Re: [PATCH net] net: nsid cannot be allocated for a dead netns

Hi Nicolas,

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Nicolas-Dichtel/net-nsid-cannot-be-allocated-for-a-dead-netns/20161116-164739
config: sparc-defconfig (attached as .config)
compiler: sparc-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc 

All error/warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/timer.h:4,
                    from include/linux/workqueue.h:8,
                    from net/core/net_namespace.c:3:
   net/core/net_namespace.c: In function 'alloc_netid':

quoted

arch/sparc/include/asm/atomic_32.h:32:48: error: invalid type argument of '->' (have 'atomic_t {aka struct <anonymous>}')

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                                   ^
   include/linux/compiler.h:545:25: note: in definition of macro '__ACCESS_ONCE'
      __maybe_unused typeof(x) __var = (__force typeof(x)) 0; \
                            ^

quoted

arch/sparc/include/asm/atomic_32.h:32:33: note: in expansion of macro 'ACCESS_ONCE'

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                    ^~~~~~~~~~~
   net/core/net_namespace.c:162:37: note: in expansion of macro 'atomic_read'
     if (!atomic_read(&net->count) || !&atomic_read(peer->count))
                                        ^~~~~~~~~~~

quoted

arch/sparc/include/asm/atomic_32.h:32:48: error: invalid type argument of '->' (have 'atomic_t {aka struct <anonymous>}')

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                                   ^
   include/linux/compiler.h:545:52: note: in definition of macro '__ACCESS_ONCE'
      __maybe_unused typeof(x) __var = (__force typeof(x)) 0; \
                                                       ^

quoted

arch/sparc/include/asm/atomic_32.h:32:33: note: in expansion of macro 'ACCESS_ONCE'

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                    ^~~~~~~~~~~
   net/core/net_namespace.c:162:37: note: in expansion of macro 'atomic_read'
     if (!atomic_read(&net->count) || !&atomic_read(peer->count))
                                        ^~~~~~~~~~~

quoted

arch/sparc/include/asm/atomic_32.h:32:48: error: invalid type argument of '->' (have 'atomic_t {aka struct <anonymous>}')

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                                   ^
   include/linux/compiler.h:546:19: note: in definition of macro '__ACCESS_ONCE'
     (volatile typeof(x) *)&(x); })
                      ^

quoted

arch/sparc/include/asm/atomic_32.h:32:33: note: in expansion of macro 'ACCESS_ONCE'

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                    ^~~~~~~~~~~
   net/core/net_namespace.c:162:37: note: in expansion of macro 'atomic_read'
     if (!atomic_read(&net->count) || !&atomic_read(peer->count))
                                        ^~~~~~~~~~~

quoted

arch/sparc/include/asm/atomic_32.h:32:48: error: invalid type argument of '->' (have 'atomic_t {aka struct <anonymous>}')

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                                   ^
   include/linux/compiler.h:546:26: note: in definition of macro '__ACCESS_ONCE'
     (volatile typeof(x) *)&(x); })
                             ^

quoted

arch/sparc/include/asm/atomic_32.h:32:33: note: in expansion of macro 'ACCESS_ONCE'

    #define atomic_read(v)          ACCESS_ONCE((v)->counter)
                                    ^~~~~~~~~~~
   net/core/net_namespace.c:162:37: note: in expansion of macro 'atomic_read'
     if (!atomic_read(&net->count) || !&atomic_read(peer->count))
                                        ^~~~~~~~~~~

vim +32 arch/sparc/include/asm/atomic_32.h

d550bbd4 arch/sparc/include/asm/atomic_32.h David Howells   2012-03-28  16  #include <asm/cmpxchg.h>
56d36489 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2014-03-13  17  #include <asm/barrier.h>
aea1181b arch/sparc/include/asm/atomic_32.h Sam Ravnborg    2011-12-27  18  #include <asm-generic/atomic64.h>
aea1181b arch/sparc/include/asm/atomic_32.h Sam Ravnborg    2011-12-27  19  
f5e706ad include/asm-sparc/atomic_32.h      Sam Ravnborg    2008-07-17  20  #define ATOMIC_INIT(i)  { (i) }
f5e706ad include/asm-sparc/atomic_32.h      Sam Ravnborg    2008-07-17  21  
4f3316c2 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2014-03-26  22  int atomic_add_return(int, atomic_t *);
3a1adb23 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2016-04-18  23  int atomic_fetch_add(int, atomic_t *);
3a1adb23 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2016-04-18  24  int atomic_fetch_and(int, atomic_t *);
3a1adb23 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2016-04-18  25  int atomic_fetch_or(int, atomic_t *);
3a1adb23 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2016-04-18  26  int atomic_fetch_xor(int, atomic_t *);
f05a6865 arch/sparc/include/asm/atomic_32.h Sam Ravnborg    2014-05-16  27  int atomic_cmpxchg(atomic_t *, int, int);
1a17fdc4 arch/sparc/include/asm/atomic_32.h Andreas Larsson 2014-11-05  28  int atomic_xchg(atomic_t *, int);
f05a6865 arch/sparc/include/asm/atomic_32.h Sam Ravnborg    2014-05-16  29  int __atomic_add_unless(atomic_t *, int, int);
f05a6865 arch/sparc/include/asm/atomic_32.h Sam Ravnborg    2014-05-16  30  void atomic_set(atomic_t *, int);
f5e706ad include/asm-sparc/atomic_32.h      Sam Ravnborg    2008-07-17  31  
2291059c arch/sparc/include/asm/atomic_32.h Pranith Kumar   2014-09-23 @32  #define atomic_read(v)          ACCESS_ONCE((v)->counter)
f5e706ad include/asm-sparc/atomic_32.h      Sam Ravnborg    2008-07-17  33  
4f3316c2 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2014-03-26  34  #define atomic_add(i, v)	((void)atomic_add_return( (int)(i), (v)))
4f3316c2 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2014-03-26  35  #define atomic_sub(i, v)	((void)atomic_add_return(-(int)(i), (v)))
4f3316c2 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2014-03-26  36  #define atomic_inc(v)		((void)atomic_add_return(        1, (v)))
4f3316c2 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2014-03-26  37  #define atomic_dec(v)		((void)atomic_add_return(       -1, (v)))
f5e706ad include/asm-sparc/atomic_32.h      Sam Ravnborg    2008-07-17  38  
3a1adb23 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2016-04-18  39  #define atomic_and(i, v)	((void)atomic_fetch_and((i), (v)))
3a1adb23 arch/sparc/include/asm/atomic_32.h Peter Zijlstra  2016-04-18  40  #define atomic_or(i, v)		((void)atomic_fetch_or((i), (v)))

:::::: The code at line 32 was first introduced by commit
:::::: 2291059c852706c6f5ffb400366042b7625066cd locking,arch: Use ACCESS_ONCE() instead of cast to volatile in atomic_read()

:::::: TO: Pranith Kumar [off-list ref]
:::::: CC: Ingo Molnar [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation