Re: [PATCH net-next 06/11] net: l3mdev: remove redundant calls

From
David Ahern <hidden>
Date
2016-11-07 15:49:08
Reply to
Lorenzo Colitti, 2016-11-07
On 11/7/16 3:13 AM, Lorenzo Colitti wrote:
What should we do here? It would seem that now that
netif_index_is_l3_master has been resurrected, it's appropriate to use
it here as well. The user-visible behaviour changed only two months
ago. Unless we think that RSTs should always mirror the iif, in which
case I can change our tests accordingly.
Using ingress information (iif in this case) to determine the route for a response seems appropriate.

I can send a patch to revert back to:

	if (!oif && netif_index_is_vrf(net, skb->skb_iif))
		oif = skb->skb_iif;

thanks for the report.
Thread (15 messages) 15 messages, 3 authors, last reply 2016-11-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help