Re: [PATCH 2/2] net: qcom/emac: enable flow control if requested
From: Timur Tabi <hidden>
Date: 2016-11-01 19:05:34
On 11/01/2016 01:30 PM, Timur Tabi wrote:
+ if (!phydev->pause && phydev->asym_pause) + mac |= TXFC;
I think this might be wrong, and nb8800_pause_config() has it right. This should be: if (!phydev->pause != !phydev->asym_pause) which is a logical-xor. Do you concur? -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.