Thread (3 messages) flat view 3 messages, 2 authors, 2016-10-28

Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517

From: Tony Lindgren <tony@atomide.com>
Date: 2016-10-28 15:52:20
Also in: linux-omap, lkml

* Jeroen Hofstee [off-list ref] [161028 08:33]:
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") did not only move the code for an am3517, it also
added the slave parameter, resulting in an invalid (all zero) mac address
being returned for an am3517, since it only has a single emac and the slave
parameter is pointing to the second. So simply always read the first and
valid mac-address for a ti,am3517-emac.
And others davinci_emac.c users can have more than one. So is the
reason the slave parameter points to the second instance because
of the location in the hardware?

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help