RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

-----Original Message-----
From: Y.B. Lu
Sent: Friday, October 28, 2016 2:06 PM
To: Y.B. Lu; 'Scott Wood'; 'linux-mmc@vger.kernel.org';
'ulf.hansson@linaro.org'; 'Arnd Bergmann'
Cc: 'linuxppc-dev@lists.ozlabs.org'; 'devicetree@vger.kernel.org';
'linux-arm-kernel@lists.infradead.org'; 'linux-kernel@vger.kernel.org';
'linux-clk@vger.kernel.org'; 'linux-i2c@vger.kernel.org';
'iommu@lists.linux-foundation.org'; 'netdev@vger.kernel.org'; 'Greg
Kroah-Hartman'; 'Mark Rutland'; 'Rob Herring'; 'Russell King'; 'Jochen
Friedrich'; 'Joerg Roedel'; 'Claudiu Manoil'; 'Bhupesh Sharma'; Qiang
Zhao; 'Kumar Gala'; 'Santosh Shilimkar'; Leo Li; X.B. Xie; M.H. Lian
Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

quoted

-----Original Message-----
From: Y.B. Lu
Sent: Friday, October 28, 2016 2:00 PM
To: 'Scott Wood'; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org;
Arnd Bergmann
Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org;
linux-arm- kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
linux- clk@vger.kernel.org; linux-i2c@vger.kernel.org;
iommu@lists.linux- foundation.org; netdev@vger.kernel.org; Greg
Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen
Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao;

Kumar Gala; Santosh Shilimkar; Leo Li; X.B.

quoted

Xie; M.H. Lian
Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

quoted

-----Original Message-----
From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
owner@vger.kernel.org] On Behalf Of Scott Wood
Sent: Friday, October 28, 2016 12:46 PM
To: Y.B. Lu; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org; Arnd
Bergmann
Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org;
linux-arm- kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
linux- clk@vger.kernel.org; linux-i2c@vger.kernel.org;
iommu@lists.linux- foundation.org; netdev@vger.kernel.org; Greg
Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen
Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao;

Kumar Gala; Santosh Shilimkar; Leo Li; X.B.

quoted

Xie; M.H. Lian
Subject: Re: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ
platforms

On Fri, 2016-10-28 at 11:32 +0800, Yangbo Lu wrote:

quoted

+	guts->regs = of_iomap(np, 0);
+	if (!guts->regs)
+		return -ENOMEM;
+
+	/* Register soc device */
+	machine = of_flat_dt_get_machine_name();
+	if (machine)
+		soc_dev_attr.machine = devm_kstrdup(dev, machine,
GFP_KERNEL);
+
+	svr = fsl_guts_get_svr();
+	soc_die = fsl_soc_die_match(svr, fsl_soc_die);
+	if (soc_die) {
+		soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL,
+						     "QorIQ %s", soc_die-

quoted

die);

+	} else {
+		soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL,
"QorIQ");
+	}
+	soc_dev_attr.soc_id = devm_kasprintf(dev, GFP_KERNEL,
+					     "svr:0x%08x", svr);
+	soc_dev_attr.revision = devm_kasprintf(dev, GFP_KERNEL,

"%d.%d",

quoted

quoted

quoted

+					       SVR_MAJ(svr), SVR_MIN(svr));
+
+	soc_dev = soc_device_register(&soc_dev_attr);
+	if (IS_ERR(soc_dev))
+		return PTR_ERR(soc_dev);

ioremap leaks on this error path.  Use devm_ioremap_resource().

[Lu Yangbo-B47093] Ok. I have fixed it in v14. Thanks :)

[Lu Yangbo-B47093] Sorry, used the wrong error code... Will resent it

[Lu Yangbo-B47093] The v15 had been sent. And dropped patch 'dt: bindings: update Freescale DCFG compatible',
since that work has been done by below patch on ShawnGuo's linux tree.
'dt-bindings: fsl: add LS1043A/LS1046A/LS2080A compatible for SCFG and DCFG'
https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/dt64&id=981034a2bfcaff5c95dafde24d7abfe7f9025c19

Thanks.

quoted

quoted

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc"
in the body of a message to majordomo@vger.kernel.org More majordomo
info at http://vger.kernel.org/majordomo-info.html

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu