Re: [PATCH 01/28] [v2] netfilter: nf_tables: avoid uninitialized variable warning
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2016-10-18 15:24:16
Also in:
lkml, netfilter-devel
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2016-10-18 15:24:16
Also in:
lkml, netfilter-devel
On Tue, Oct 18, 2016 at 12:05:30AM +0200, Arnd Bergmann wrote:
The newly added nft_range_eval() function handles the two possible nft range operations, but as the compiler warning points out, any unexpected value would lead to the 'mismatch' variable being used without being initialized: net/netfilter/nft_range.c: In function 'nft_range_eval': net/netfilter/nft_range.c:45:5: error: 'mismatch' may be used uninitialized in this function [-Werror=maybe-uninitialized] This removes the variable in question and instead moves the condition into the switch itself, which is potentially more efficient than adding a bogus 'default' clause as in my first approach, and is nicer than using the 'uninitialized_var' macro.
Applied to the nf tree, thanks Arnd.