Re: linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor error checking ?

Hi David,
On Mon, 2016-10-17 at 07:40 +0000, David Binderman wrote:

Hello there,

linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561]: (style) Checking if unsigned variable 'len' is less than zero.

Source code is

    len = min((size_t)le32_to_cpu(rsp->len) << 2,
          iwl_rx_packet_payload_len(hcmd.resp_pkt) - sizeof(*rsp));
    len = min(len - delta, count);
    if (len < 0) {
        ret = -EFAULT;
        goto out;
    }

Suggest improve error checking.

Thanks for reporting! A fix for this is already queued in our internal
tree and will be sent upstream soon.

--
Cheers,
Luca.