Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver

On Thu, Oct 13, 2016 at 10:09:09AM +0200, Stefan Wahren wrote:

quoted

Stefan Wahren [off-list ref] hat am 26. September 2016 um 13:07
geschrieben:


The Qualcomm QCA7000 HomePlug GreenPHY supports two interfaces:
UART and SPI. This patch series adds the missing support for UART.

This driver based on the Qualcomm code [1], but contains some changes:
* use random MAC address per default
* use net_device_stats from device
* share frame decoding between SPI and UART driver
* improve error handling
* reimplement tty_wakeup with work queue (based on slcan)

The patches 1 - 3 are just for clean up and are not related to
the UART support. Patches 4 - 7 prepare the existing QCA7000
code for UART support. The last patch contains the new driver.

In order to test the driver a modified slattach in userspace is also
required. A prepared busybox (includes slattach) can be found here [2].

The code itself has been tested on a Freescale i.MX28 board.

Changes in v2:
  * fix build issue by using netif_trans_update() and dev_trans_start()

[1] - https://github.com/IoE/qca7000
[2] - https://github.com/lategoodbye/busybox/commits/qca7k_support_1_24

Gently ping, since i didn't receive any comment for this version.

Wait, this is an RFC, hah, I don't ever review those as obviously you
don't think well enough of it to be proposing this for inclusion :)

Fix up what you think needs to be done and resend it "for real" and it
will enter my review queue.

thanks,

greg k-h