Thread (3 messages) flat view 3 messages, 3 authors, 2016-10-07

Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2016-10-06 11:04:52
Also in: linux-devicetree, lkml

On 10/05/2016 07:03 AM, Mike Looijmans wrote:
The KSZ9031 skew registers contain an offset, the chip's default value
is "neutral" which does not add any skew. Programming a 0 into a skew
property will actually set it the maximal negative adjustment and not
to a neutral position as one would expect.

Explain this situation in the devicetree binding documentation and list
the settings that the chip considers neutral.

Changing the implementation to accept negative values would have been
a better solution, but would break existing configurations.

Signed-off-by: Mike Looijmans <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help