Re: [PATCH] net: ethernet: mediatek: mark symbols static where possible

From
David Miller <davem@davemloft.net>
Date
2016-10-03 05:24:38
Also in
linux-arm-kernel, linux-mediatek, lkml
Reply to
Baoyou Xie, 2016-09-30
From: Baoyou Xie <redacted>
Date: Fri, 30 Sep 2016 15:48:50 +0800
We get 2 warnings when building kernel with W=1:
drivers/net/ethernet/mediatek/mtk_eth_soc.c:2041:5: warning: no previous prototype for 'mtk_get_link_ksettings' [-Wmissing-prototypes]
drivers/net/ethernet/mediatek/mtk_eth_soc.c:2052:5: warning: no previous prototype for 'mtk_set_link_ksettings' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <redacted>
Applied, thanks.
Thread (2 messages) 2 messages, 2 authors, last reply 2016-10-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help