Re: [patch net] mlxsw: spectrum: Fix incorrect reuse of MID entries
From: Ido Schimmel <hidden>
Date: 2016-10-31 20:36:44
Hi, On Mon, Oct 31, 2016 at 03:36:06PM -0400, David Miller wrote:
From: Jiri Pirko <jiri@resnulli.us> Date: Sun, 30 Oct 2016 10:09:22 +0100quoted
From: Ido Schimmel <redacted> In the device, a MID entry represents a group of local ports, which can later be bound to a MDB entry. The lookup of an existing MID entry is currently done using the provided MC MAC address and VID, from the Linux bridge. However, this can result in an incorrect reuse of the same MID index in different VLAN-unaware bridges (same IP MC group and VID 0). Fix this by performing the lookup based on FID instead of VID, which is unique across different bridges. Fixes: 3a49b4fde2a1 ("mlxsw: Adding layer 2 multicast support") Signed-off-by: Ido Schimmel <redacted> Acked-by: Elad Raz <redacted> Signed-off-by: Jiri Pirko <redacted>Applied, should I queue this up for -stable?
I don't think it's necessary, but thanks for asking! We recently picked up the habit of noting what we would like to see in -stable.