Thread (27 messages) flat view 27 messages, 4 authors, 2016-10-21

Re: Need help with mdiobus_register and phy

From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-10-14 13:18:54

On Fri, Oct 14, 2016 at 08:03:18AM -0500, Timur Tabi wrote:
Andrew Lunn wrote:
quoted
Have you tried using the ethernet-phy-id device tree property? It
looks like that will allow you to skip get_phy_device and just create
the phy device. You can then bring the phy out of sleep in the probe
function?
The problem I'm experiencing is with ACPI, so I can't use any of the
fancy of_ apis like of_get_phy_id().  But I'll look into it.

Is it possible that at803x_suspend() is too aggressive?  That's it's
effectively disabling the phy?  While the phy is suspended, should
it still respond to MII_PHYSID1 and MII_PHYSID2 requests?
That is a basic assumption of the code. If you cannot read the IDs how
are you supposed to know what device it is, and what quirks you need
to work around its broken features...

Does the datasheet say anything about this?

I would say for this device, suspend() is too aggressive.

  Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help