Re: [PATCH net-next 0/5] udp: Flow dissection for tunnels

From: Tom Herbert <redacted>
Date: Wed, 12 Oct 2016 16:25:42 -0700

Since performing a UDP lookup on every packet might be expensive I
added a static key check to bypass the lookup if there are no
sockets with flow_dissect set. I should mention that doing the
lookup wasn't particularly a big hit anyway.

I think this new static key is unnecessary, as it is equivalent
to: (udp_encap_needed + udpv6_encap_needed)

This socket lookup is very heavy handed, and I realize that you
need this because we no longer store the encapsulation socket in
skb->sk these days.

Can you talk about the various code paths that lead into the
flow dissector and why the UDP socket lookup is needed?  Maybe
we can propagate it another way, at least on TX.

Thanks.