Re: [PATCH net-next 5/6] qed: Allow chance for fast ramrod completions

From: "Mintz, Yuval" <redacted>
Date: Mon, 10 Oct 2016 06:33:05 +0000

quoted

quoted

+     while (iter_cnt--) {
+             /* Validate we receive completion update */
               smp_rmb();
               if (comp_done->done == 1) {
                       if (p_fw_ret)
                               *p_fw_ret = comp_done->fw_return_code;
                       return 0;
               }

quoted

Note that this smp_rmb() and accesses to ->done and ->fw_return_code are
racy.

quoted

fw_return_code needs to be written _before_ done.

Thanks for catching this up.

Dave  - do you want me to re-spin for this?

Yes.