Thread (3 messages) flat view 3 messages, 3 authors, 2016-10-17

Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()

From: Phil Sutter <phil@nwl.cc>
Date: 2016-10-09 09:07:10

On Sun, Oct 09, 2016 at 10:14:18AM +0800, Hangbin Liu wrote:
Discovered by Phil's covscan. The final return statement is never reached.
This is not inherently clear from looking at the code, so change the
conditional to a switch() statement which should clarify this.

CC: Phil Sutter <phil@nwl.cc>
Signed-off-by: Hangbin Liu <redacted>
Acked-by: Phil Sutter <phil@nwl.cc>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help