On Wed, 5 Oct 2016 22:22:13 -0700, Pravin Shelar wrote:
User can turn off TX vlan offload for OVS internal device that would
allow vlan tagged packet with vlan header on the skb-data. This case
will cause issue here.
Good catch. This is the feedback I hoped for, not the bikesheding about
a value of unused variable :-)
We could handle this case by not allowing this configuration.
I'm not sure how clean this is but let's try and see if anyone objects.
I'll send v3.
I also noticed we don't set NETIF_F_HW_VLAN_STAG_TX on internal ports.
I'll fix it, too.
Thanks!
Jiri