Hi Andrew,

Thank you for review and valuable comments.

Thanks,
Raju.
On Tue, Sep 27, 2016 at 04:16:33PM +0200, Andrew Lunn wrote:

EXTERNAL EMAIL

quoted

index 0000000..7ba3855

--- /dev/null
+++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt

@@ -0,0 +1,61 @@
+* Microsemi - vsc8531 Giga bit ethernet phy
+
+Required properties:
+- compatible : Should contain phy id as "ethernet-phy-idAAAA.BBBB"
+               If the phy's identifier is known then the list may contain an entry
+               of the form: "ethernet-phy-idAAAA.BBBB" where
+               AAAA - The value of the 16 bit Phy Identifier 1 register as
+                      4 hex digits. This is the chip vendor OUI bits 3:18
+               BBBB - The value of the 16 bit Phy Identifier 2 register as
+                      4 hex digits. This is the chip vendor OUI bits 19:24,
+                      followed by 10 bits of a vendor specific ID.
+- reg                : The ID number for the phy, usually a small integer

Please don't copy phy.txt. Just refer to it. Use text like:

The PHY device uses the binding described in
Documentation/devicetree/bindings/net/phy.txt

It may additionally have the following properties

Accepted. 

quoted

+Optional properties:
+- vsc8531,edge-rate  : Edge rate sets the drive strength of the MAC
+                       interface output signals.  Changing the drive
+                       strength will affect the edge rate of the output
+                       signal.

Are we specifying a rate or a strength? It is called edge-rate, so it
expect it to be a rate, mV/pS or something similar.

Accepted.

       Andrew