Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

On Tue, Sep 27, 2016 at 04:26:59PM +0200, Allan W. Nielsen wrote:

Hi Andrew,

quoted

quoted

+Optional properties:
+- vsc8531,edge-rate  : Edge rate sets the drive strength of the MAC
+                       interface output signals.  Changing the drive
+                       strength will affect the edge rate of the output
+                       signal.

Are we specifying a rate or a strength? It is called edge-rate, so it
expect it to be a rate, mV/pS or something similar.

I do not know - sorry.

The text needs to be consistent with the property name. The text
suggests this setting affects the drive strength. As a result of the
drive strength, the edge rate will differ. Cause and effect.

So maybe the correct units here is mA?

	Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html