Re: [PATCH 3/6] isdn/hisax: add function declarations
flat view
From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-09-24 08:47:51
Also in:
lkml
On Saturday, September 24, 2016 1:21:47 PM CEST Baoyou Xie wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/isdn/hisax/config.c +++ b/drivers/isdn/hisax/config.c@@ -460,42 +460,14 @@ __setup("hisax=", HiSax_setup); extern int setup_teles0(struct IsdnCard *card); #endif -#if CARD_TELES3 -extern int setup_teles3(struct IsdnCard *card); -#endif
...
quoted hunk ↗ jump to hunk
-#if CARD_TELESPCI -extern int setup_telespci(struct IsdnCard *card); -#endif - #if CARD_AVM_A1 extern int setup_avm_a1(struct IsdnCard *card); #endif
It seems odd that you remove some but not all declarations here. Please do all of them at once.
quoted hunk ↗ jump to hunk
@@ -1350,3 +1350,63 @@ static inline struct pci_dev *hisax_find_pci_device(unsigned int vendor, } #endif + +#if CARD_TELES3 +int setup_teles3(struct IsdnCard *card); +#endif + +#if CARD_TELESPCI +int setup_telespci(struct IsdnCard *card); +#endif +
When you add the declarations here, just leave out the #if guards, and put all the declarations here unconditionally, as we normally do in the kernel. Arnd