Thread (21 messages) 21 messages, 3 authors, 2016-09-24

Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser

flat view

From: David Howells <dhowells@redhat.com>
Date: 2016-09-23 18:20:39
Also in: lkml

Sergei Shtylyov [off-list ref] wrote:
quoted
 		case RXRPC_ACK_TYPE_NACK:
 			if (anno_type == RXRPC_TX_ANNO_NAK)
 				continue;
+			if (anno_type == RXRPC_TX_ANNO_RETRANS)
+				continue;
   Why not fold the above 2 *if*s together? Or use *else if* at least?
I have a pending patch that adds something between them.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help