On Tue, Sep 20, 2016 at 06:47:02PM -0400, Nicolas Pitre wrote:
IMHO it is much nicer for the poor user configuring the kernel to have a
single configuration prompt for PTP support, and then have whatever
driver that can provide a PTP clock just do it (or omit it) based on
that single prompt. Prompting for PTP support for each individual
ethernet driver is silly.
Embedded people like to optimize their systems. One pattern I have
more than once is that a multihomed design designates a special PTP
interface, often with a different HW than the other ports. PTP
support adds extra code into the hot path, and for that reason people
want to turn it off on interfaces that don't need it.
So Thomas' idea is a better solution. It reduces the tinification in
this area to a careful kernel configuration. Yes, that is more work
to configure than having one "big red button" to push. The burden is
on the tinification user to get this right, and that is the right way,
IMHO. After all, this can be scripted, and such users have to
configure very carefully in any case.
Thanks,
Richard