Thread (2 messages) 2 messages, 2 authors, 2016-09-20

Re: [PATCH] net: hns: mark symbols static where possible

flat view

From: David Miller <davem@davemloft.net>
Date: 2016-09-20 01:56:41
Also in: lkml

From: Baoyou Xie <redacted>
Date: Sun, 18 Sep 2016 17:07:25 +0800
We get a few warnings when building kernel with W=1:
drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes]
drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes]
drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous prototype for 'hns_ae_get_handle' [-Wmissing-prototypes]
....

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <redacted>
Does not apply cleanly to net-next, please respin.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help