Re: [PATCH] net/mlx4_en: fix off by one in error handling

On 14/09/2016 2:09 PM, Sebastian Ott wrote:

quoted

If an error occurs in mlx4_init_eq_table the index used in the
err_out_unmap label is one too big which results in a panic in
mlx4_free_eq. This patch fixes the index in the error path.

You are right, but your change below does not cover all cases.
The full solution looks like this:

@@ -1260,7 +1260,7 @@ int mlx4_init_eq_table(struct mlx4_dev *dev)
                                             eq);
                }
                if (err)
-                       goto err_out_unmap;
+                       goto err_out_unmap_excluded;