Re: [PATCH v2 6/6] selftests: move watchdog tests from Documentation/watchdog

On 09/13/2016 02:33 PM, Timur Tabi wrote:

Shuah Khan wrote:

quoted

Remove watchdog-test from Makefile to move the test to selftests.

Add Makefile and .gitignore to for watchdog-test. watchdog-test will

to for?

Thanks - will fix that.

quoted

not be run as part of selftests suite and will not be included in
install targets.  It can be built separately for now.

Signed-off-by: Shuah Khan <redacted>
---
  Documentation/watchdog/src/.gitignore            |   1 -
  Documentation/watchdog/src/Makefile              |   2 +-
  Documentation/watchdog/src/watchdog-test.c       | 105 -----------------------
  tools/testing/selftests/watchdog/.gitignore      |   1 +
  tools/testing/selftests/watchdog/Makefile        |   8 ++
  tools/testing/selftests/watchdog/watchdog-test.c | 105 +++++++++++++++++++++++

Please use -M when calling git-format-patch

okay.

quoted

  6 files changed, 115 insertions(+), 107 deletions(-)
  delete mode 100644 Documentation/watchdog/src/watchdog-test.c
  create mode 100644 tools/testing/selftests/watchdog/.gitignore
  create mode 100644 tools/testing/selftests/watchdog/Makefile
  create mode 100644 tools/testing/selftests/watchdog/watchdog-test.c

diff --git a/Documentation/watchdog/src/.gitignore b/Documentation/watchdog/src/.gitignore
index ac90997..ff0ebb5 100644
--- a/Documentation/watchdog/src/.gitignore
+++ b/Documentation/watchdog/src/.gitignore

@@ -1,2 +1 @@
  watchdog-simple
-watchdog-test

Why not also watchdog-simple?

Is watchdog-simple a test or a sample/example? I thought this
is an example, and planning to move that under examples?

If this is a test, I will re-do the patch to include it.

thanks,
-- Shuah

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html