Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver

On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote:

Hi Corentin

quoted

+static int sun8i_emac_mdio_register(struct net_device *ndev)
+{
+	struct sun8i_emac_priv *priv = netdev_priv(ndev);
+	struct mii_bus *bus;
+	int ret;
+
+	bus = mdiobus_alloc();

You can use devm_mdiobus_alloc() which will simplify your error
handling and unregister code.

	 Andrew

Hello

Since the mdio bus is allocated on ndev/open, it need to be removed when ndev/stop is called.
So devm_mdiobus_alloc cannot be used.

Regards

Corentin Labbe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html