Re: [PATCH] [RFC] proc connector: add namespace events
flat view
From: Evgeniy Polyakov <hidden>
Date: 2016-09-12 21:39:49
Also in:
lkml
Hi everyone 08.09.2016, 18:39, "Alban Crequy" [off-list ref]:
The act of a process creating or joining a namespace via clone(), unshare() or setns() is a useful signal for monitoring applications.
quoted hunk ↗ jump to hunk
+ if (old_ns->mnt_ns != new_ns->mnt_ns) + proc_ns_connector(tsk, CLONE_NEWNS, PROC_NM_REASON_CLONE, old_mntns_inum, new_mntns_inum); + + if (old_ns->uts_ns != new_ns->uts_ns) + proc_ns_connector(tsk, CLONE_NEWUTS, PROC_NM_REASON_CLONE, old_ns->uts_ns->ns.inum, new_ns->uts_ns->ns.inum); + + if (old_ns->ipc_ns != new_ns->ipc_ns) + proc_ns_connector(tsk, CLONE_NEWIPC, PROC_NM_REASON_CLONE, old_ns->ipc_ns->ns.inum, new_ns->ipc_ns->ns.inum); + + if (old_ns->net_ns != new_ns->net_ns) + proc_ns_connector(tsk, CLONE_NEWNET, PROC_NM_REASON_CLONE, old_ns->net_ns->ns.inum, new_ns->net_ns->ns.inum); + + if (old_ns->cgroup_ns != new_ns->cgroup_ns) + proc_ns_connector(tsk, CLONE_NEWCGROUP, PROC_NM_REASON_CLONE, old_ns->cgroup_ns->ns.inum, new_ns->cgroup_ns->ns.inum); + + if (old_ns->pid_ns_for_children != new_ns->pid_ns_for_children) + proc_ns_connector(tsk, CLONE_NEWPID, PROC_NM_REASON_CLONE, old_ns->pid_ns_for_children->ns.inum, new_ns->pid_ns_for_children->ns.inum); + } +
Patch looks good to me from technical/connector point of view, but these even multiplication is a bit weird imho. I'm not against it, but did you consider sending just 2 serialized ns structures via single message, and client would check all ns bits himself?