Thread (35 messages) 35 messages, 10 authors, 2016-09-14

Re: [PATCH 23/26] sh_eth: constify local structures

From: Julia Lawall <hidden>
Date: 2016-09-12 08:55:40
Also in: kernel-janitors, linux-renesas-soc, lkml


On Sun, 11 Sep 2016, Sergei Shtylyov wrote:
On 09/11/2016 04:06 PM, Julia Lawall wrote:
quoted
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
  Really?
quoted
2. Address never taken
  Really?
quoted
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.

Done using Coccinelle.
Based on a suggestion by Joe Perches [off-list ref].

Signed-off-by: Julia Lawall <redacted>
   NAK, see sh_eth_set_default_cpu_data().
Thanks for the feedback.  I will check on why this slipped through.
Perhaps it is a variability (ifdef) problem.

julia
MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help