RE: [PATCH v2] qed: mark symbols static where possible
flat view
From: Yuval Mintz <hidden>
Date: 2016-09-08 12:37:18
Also in:
lkml
.... In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'.
...
quoted hunk ↗ jump to hunk
-void qed_get_vport_stats(struct qed_dev *cdev, - struct qed_eth_stats *stats) +static void qed_get_vport_stats(struct qed_dev *cdev, + struct qed_eth_stats *stats)
Looks like you've missed my comment from v1 -
1. qed_get_vport_stats() is in use in net-next by qed_main.c starting
with
6c75424612a7 ("qed: Add support for NCSI statistics."), so we
shouldn't make it static.Besides, it still doesn't apply to net-next [as net-next has function declaration as a single liner].