RE: [PATCH] qed: add missing header dependencies
flat view
From: Yuval Mintz <hidden>
Date: 2016-09-07 11:51:16
Also in:
lkml
We get 4 warnings when building kernel with W=1: drivers/net/ethernet/qlogic/qed/qed_selftest.c:6:5: warning: no previous prototype for 'qed_selftest_memory' [-Wmissing-prototypes] drivers/net/ethernet/qlogic/qed/qed_selftest.c:19:5: warning: no previous prototype for 'qed_selftest_interrupt' [-Wmissing-prototypes] drivers/net/ethernet/qlogic/qed/qed_selftest.c:32:5: warning: no previous prototype for 'qed_selftest_register' [-Wmissing-prototypes] drivers/net/ethernet/qlogic/qed/qed_selftest.c:55:5: warning: no previous prototype for 'qed_selftest_clock' [-Wmissing-prototypes] In fact, these functions are declared in qed_selftest.h, so this patch add missing header dependencies. Signed-off-by: Baoyou Xie <redacted>
While I obviously have no strong objection for including qed_selftest.h from qed_selftest.c, I'm not sure I understand which C standard dictates this requirement. Why should a function definition [not call] be preceded by a prototype?