Thread (7 messages) 7 messages, 5 authors, 2016-09-08

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

flat view

From: Alexei Starovoitov <hidden>
Date: 2016-09-06 15:34:01
Also in: lkml

On Tue, Sep 06, 2016 at 03:10:22PM +0200, Arnd Bergmann wrote:
The newly added bpf_overflow_handler function is only built of both
CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller
only checks the latter:

kernel/events/core.c: In function 'perf_event_alloc':
kernel/events/core.c:9106:27: error: 'bpf_overflow_handler' undeclared (first use in this function)

This changes the caller so we also skip this call if CONFIG_EVENT_TRACING
is disabled entirely.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: aa6a5f3cb2b2 ("perf, bpf: add perf events core support for BPF_PROG_TYPE_PERF_EVENT programs")
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I'm not entirely sure if this is the correct solution, please check before applying
Acked-by: Alexei Starovoitov <ast@kernel.org>

Thanks for the fix. Just saw build bot complaining last night and
by the morning your fix is already here. Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help