Re: [PATCH net-next V2] net/sched: pkt_cls: change tc actions order to be as the user sets
flat view
From: Hadar Hen Zion <hidden>
Date: 2016-09-27 09:15:24
On Tue, Sep 27, 2016 at 11:09 AM, Hadar Hen Zion [off-list ref] wrote:
Currently the created tc actions list is reversed against the order set by the user. Change the actions list order to be the same as was set by the user. This patch doesn't affect dump actions behavior. For dumping, action->order parameter is used so the list order doesn't matter. Signed-off-by: Hadar Hen Zion <redacted> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Changes from V1: - Add a comment to the change log
quoted hunk ↗ jump to hunk
--- include/net/pkt_cls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 5ccaa4b..767b03a 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h@@ -123,7 +123,7 @@ static inline void tcf_exts_to_list(const struct tcf_exts *exts, for (i = 0; i < exts->nr_actions; i++) { struct tc_action *a = exts->actions[i]; - list_add(&a->list, actions); + list_add_tail(&a->list, actions); } #endif } --1.8.3.1