RE: [PATCH net v2 0/2] Fix tc-ife bugs

-----Original Message-----
From: Jamal Hadi Salim [mailto:jhs@mojatatu.com]
Sent: Monday, September 26, 2016 3:47 AM
To: Yotam Gigi <redacted>; Yotam Gigi <yotam.gi@gmail.com>;
davem@davemloft.net; netdev@vger.kernel.org
Cc: Jiri Pirko <redacted>; Elad Raz <redacted>; mlxsw
[off-list ref]; Roman Mashak [off-list ref]
Subject: Re: [PATCH net v2 0/2] Fix tc-ife bugs

On 16-09-25 07:17 PM, Jamal Hadi Salim wrote:
[..]

quoted

quoted

Do you prefer that I will fix the encode side to encode the whole tlv
header
size instead of fixing the decode side?

Yes please - Add NLA_HDRLEN to the dlen on the encode you showed above.

OK. Did it and tested it. Everything seems functional.

quoted

And the correct commit it fixes is:
a823f93750e341bc0d6829a00019435b96830fd4

I can't find this commit. Where is it? 

Don't you mean that commit: 28a10c426e81afc88514bca8e73affccf850fdf6
with title: "net sched: fix encoding to use real length"?

I removed the padding but also the headerlen when i did
that. Tested with tc_index which is a u16 was the mistake i made.

cheers,
jamal