Thread (8 messages) 8 messages, 4 authors, 2016-09-27

Re: [PATCH net-next] net/sched: pkt_cls: change tc actions order to be as the user sets

flat view

From: Cong Wang <hidden>
Date: 2016-09-26 04:32:01

On Sun, Sep 25, 2016 at 7:39 AM, Jamal Hadi Salim [off-list ref] wrote:
On 16-09-25 10:08 AM, Hadar Hen Zion wrote:
quoted
Currently the created tc actions list is reversed against the order
set by the user.
Change the actions list order to be the same as was set by the user.

Did something break? It seems to matter most for dumping. But even that
didnt breaking. Looking at the latest net tree, i tried:
The reason is we use action->order as an nested attribute, so
the order in the list doesn't matter, only action->order itself matters.

See tcf_action_dump():

   nest = nla_nest_start(skb, a->order);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help