Thread (4 messages) 4 messages, 3 authors, 2016-09-24

Re: [PATCH net v2] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()

flat view

From: David Miller <davem@davemloft.net>
Date: 2016-09-24 13:45:21

From: Lance Richardson <redacted>
Date: Fri, 23 Sep 2016 15:50:29 -0400
Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in
xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup.

Up until now, ip6gre_xmit_other() has set flowi6_proto to a bogus value.
This affected output route lookup for packets sent on an ip6gretap device
in cases where routing was dependent on the value of flowi6_proto.

Since the correct proto is already set in the tunnel flowi6 template via
commit 252f3f5a1189 ("ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit
path."), simply delete the line setting the incorrect flowi6_proto value.

Suggested-by: Jiri Benc <redacted>
Fixes: commit c12b395a4664 ("gre: Support GRE over IPv6")
Reviewed-by: Shmulik Ladkani <redacted>
Signed-off-by: Lance Richardson <redacted>
---
v2: expanded commit description as suggested by Shmulik Ladkani.
Applied and queued up for -stable with Fixes tag fixes up.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help