Re: [PATCH] net: bcmgenet: Fix EPHY reset in power up

From
Jaedon Shin <hidden>
Date
2016-09-23 15:04:26
Reply to
Andrew Lunn, 2016-09-23
Hi Andrew,

On 23 Sep 2016, at 11:06 PM, Andrew Lunn [off-list ref] wrote:
On Fri, Sep 23, 2016 at 10:20:04PM +0900, Jaedon Shin wrote:
quoted
The bcmgenet_mii_reset() is always not running in power up sequence
after 'commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from
struct net_device")'. This'll show extremely high latency and duplicate
packets while interface down and up repeatedly.

For now, adds again a private phydev for mii reset when runs power up to
open interface.
Hi Jaedon

How does this fix the issue? It sounds like you are papering over the
crack, not truly fixing it.

      Andrew
Yes, It feel like a workaround, but I think it must need v4.8 stable
version. If we find better way that fixes internal PHY to initialize
after re-open interface, this patch will be dropped.

Additionally,
http://www.spinics.net/lists/netdev/msg350506.html

Thanks,
Jaedon
Thread (5 messages) 5 messages, 3 authors, last reply 2016-09-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help