Thread (3 messages) 3 messages, 3 authors, 2016-09-22

Re: [PATCH iproute2 net-next] tc: m_vlan: Add vlan modify action

flat view

From: Shmulik Ladkani <hidden>
Date: 2016-09-22 17:44:58

On Thu, 22 Sep 2016 09:05:04 -0700 Stephen Hemminger [off-list ref] wrote:
On Thu, 22 Sep 2016 12:31:10 +0300
Shmulik Ladkani [off-list ref] wrote:
quoted
+
+static const char *action_name(int action)
+{
+	static const char * const names[] = {
+		[TCA_VLAN_ACT_POP] = "pop",
+		[TCA_VLAN_ACT_PUSH] = "push",
+		[TCA_VLAN_ACT_MODIFY] = "modify",
+	};
+	return names[action];
+}
+  
Why are you wrapping a simple array lookup in a function?
No reason in particular, was probably code evolution, will amend, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help