Re: [PATCH] net: fec: set mac address unconditionally

Hello,

just a few nitpicks:

On Wed, Sep 21, 2016 at 03:30:55PM +0200, Gavin Schenk wrote:

Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac address")

This line belongs to in the S-o-B area below.

If the mac address origin is not dt, you can only safe assign a

s/safe/safely/

mac address after "link up" of the device. If the link is down the
clocks are disabled and because of issues assigning registers when
clocks are down the new mac address is discarded on some soc's. This fix

s/down/off/; s/is discarded/cannot be written in .ndo_set_mac_address()/

sets the mac address unconditionally in fec_restart(...) and ensures
consistens between fec registers and the network layer.

s/consistens/consistency/

Other than that:

Acked-by: Uwe Kleine-König <redacted>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |