Thread (7 messages) 7 messages, 5 authors, 2016-09-21

Re: [PATCH net-next V2] net/vxlan: Avoid unaligned access in vxlan_build_skb()

flat view

From: Alexei Starovoitov <hidden>
Date: 2016-09-21 16:15:08

On Wed, Sep 21, 2016 at 12:10:55PM +0200, Hannes Frederic Sowa wrote:
On 20.09.2016 20:57, Sowmini Varadhan wrote:
quoted
The vxlan header may not be aligned to 4 bytes in
vxlan_build_skb (e.g., for MLD packets). This patch
avoids unaligned access traps from vxlan_build_skb
(in platforms like sparc) by making struct vxlanhdr __packed.

Signed-off-by: Sowmini Varadhan <redacted>
Performance wise this should only affect code generation for archs where
it matters anyway.
I think it's the opposite. Even on x86 compiler will use byte loads.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help