Thread (32 messages) 32 messages, 9 authors, 2016-09-30

Re: [PATCH v4 net-next 01/16] tcp: cdg: rename struct minmax in tcp_cdg.c to avoid a naming conflict

flat view

From: Kenneth Klette Jonassen <hidden>
Date: 2016-09-20 16:40:03

On Tue, Sep 20, 2016 at 5:39 AM, Neal Cardwell [off-list ref] wrote:
From: Soheil Hassas Yeganeh <redacted>

The upcoming change "lib/win_minmax: windowed min or max estimator"
introduces a struct called minmax, which is then included in
include/linux/tcp.h in the upcoming change "tcp: use windowed min
filter library for TCP min_rtt estimation". This would create a
compilation error for tcp_cdg.c, which defines its own minmax
struct. To avoid this naming conflict (and potentially others in the
future), this commit renames the version used in tcp_cdg.c to
cdg_minmax.

Signed-off-by: Soheil Hassas Yeganeh <redacted>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Yuchung Cheng <redacted>
Signed-off-by: Eric Dumazet <redacted>
Cc: Kenneth Klette Jonassen <redacted>
Acked-by: Kenneth Klette Jonassen <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help