Re: [PATCH net-next 7/8] net/mlx5e: XDP TX forwarding support

On Tue, Sep 20, 2016 at 8:40 AM, Alexei Starovoitov
[off-list ref] wrote:

On Tue, Sep 20, 2016 at 03:53:10PM +0300, Tariq Toukan wrote:

quoted

quoted

quoted

quoted

+  case XDP_ABORTED:

It is not clearly defined, but I believe XDP_ABORTED should also result
in a warning (calling bpf_warn_invalid_xdp_action(act)).

I'll add this.

Certainly NOT.
XDP_ABORTED is an exception case when program does divide by zero.
It should NOT do bpf_warn. It must drop the packet.
We discussed it several months ago.
See mlx4/en_rx.c for canonical implementation.

It should at least bump a counter so that the user knows that aborts
are happening.