Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

On 09/19/2016 02:10 PM, Eric Dumazet wrote:

On Mon, Sep 19, 2016 at 1:57 PM, Stephen Hemminger
[off-list ref] wrote:

quoted

Looks good, but could I suggest a simple optimization.
All these parameters are immutable in the version of BBR you are submitting.
Why not make the values const? And eliminate the always true long-term bw estimate
variable?

We could do that.

We used to have variables (aka module params) while BBR was cooking in
our kernels ;)

Are there better than epsilon odds of someone perhaps wanting to poke those values as it gets exposure beyond Google?

happy benchmarking,

rick jones